Pil0tXia commented on code in PR #4507:
URL: https://github.com/apache/eventmesh/pull/4507#discussion_r1370379273
##########
eventmesh-connectors/eventmesh-connector-jdbc/src/main/java/org/apache/eventmesh/connector/jdbc/connection/JdbcConnection.java:
##########
@@ -76,6 +73,29 @@ public JdbcConnection(JdbcConfig jdbcConfig,
InitialOperation initialOperation,
}
}
+ /**
+ * Creates a ConnectionFactory that uses a pattern-based URL with
placeholder values.
+ *
+ * @param urlWithPlaceholder The URL pattern with placeholders.
+ * @param replaces The replacement values for the placeholders.
+ * @return The ConnectionFactory instance.
+ */
+ @SuppressWarnings("unchecked")
+ public static ConnectionFactory createPatternConnectionFactory(String
urlWithPlaceholder, String... replaces) {
+ return config -> {
Review Comment:
This static method is called by another class, so you shouldn't move its
position and it is recommended to leave it where it was at the bottom of this
class.
There are other similar places, such as private enums in `MysqlCdcEngine`
and those changes should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
