pandaapo commented on code in PR #4524: URL: https://github.com/apache/eventmesh/pull/4524#discussion_r1377271497
########## eventmesh-admin/src/main/java/org/apache/eventmesh/admin/enums/Status.java: ########## @@ -17,60 +17,60 @@ package org.apache.eventmesh.admin.enums; -import static org.apache.eventmesh.admin.common.ConfigConst.COLON; +import static org.apache.eventmesh.admin.constant.ConfigConst.COLON; import org.springframework.http.HttpStatus; import lombok.Getter; /** - * An enumeration class that conforms to the RESTful specifications and custom error reporting requirements. + * An error enumeration class that conforms to the RESTful specifications and custom error reporting requirements. Review Comment: This class contains `SUCCESS`, why did you deliberately modify the description to emphasize it as `An error enumeration class` after changing the class name from `Errors` to `Status`? --- 这个类包含`SUCCESS`，为什么在将类名从`Errors`改成`Status`以后，又特意修改描述强调它是`An error enumeration class`？ ########## eventmesh-admin/src/main/java/org/apache/eventmesh/admin/enums/Status.java: ########## @@ -17,60 +17,60 @@ package org.apache.eventmesh.admin.enums; -import static org.apache.eventmesh.admin.common.ConfigConst.COLON; +import static org.apache.eventmesh.admin.constant.ConfigConst.COLON; import org.springframework.http.HttpStatus; import lombok.Getter; /** - * An enumeration class that conforms to the RESTful specifications and custom error reporting requirements. + * An error enumeration class that conforms to the RESTful specifications and custom error reporting requirements. Review Comment: This class contains `SUCCESS`, why did you deliberately modify the description to emphasize it as `An error enumeration class` after changing the class name from `Errors` to `Status`? --- 这个类包含`SUCCESS`，为什么在将类名从`Errors`改成`Status`以后，又特意修改描述强调它是`An error enumeration class`？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
