pandaapo commented on code in PR #4561:
URL: https://github.com/apache/eventmesh/pull/4561#discussion_r1395748394
##########
eventmesh-connectors/eventmesh-connector-openfunction/src/test/java/org/apache/eventmesh/connector/openfunction/source/connector/OpenFunctionSourceConnectorTest.java:
##########
@@ -0,0 +1,51 @@
+package org.apache.eventmesh.connector.openfunction.source.connector;
+
+import
org.apache.eventmesh.connector.openfunction.source.config.OpenFunctionSourceConfig;
+import org.apache.eventmesh.openconnect.offsetmgmt.api.data.ConnectRecord;
+import org.apache.eventmesh.openconnect.offsetmgmt.api.data.RecordOffset;
+import org.apache.eventmesh.openconnect.offsetmgmt.api.data.RecordPartition;
+
+import java.util.List;
+import java.util.concurrent.BlockingQueue;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Spy;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)
+public class OpenFunctionSourceConnectorTest {
+
+ @Spy
+ private OpenFunctionSourceConnector connector;
Review Comment:
This `@Spy` annotation is redundant, because you completely manually
constructed `connector` without simulating it. Because `@Spy` is redundant,
`@ExtendWith(MockitoExtension.class)` also becomes redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
