xwm1992 commented on code in PR #4578:
URL: https://github.com/apache/eventmesh/pull/4578#discussion_r1405335316
##########
eventmesh-meta/eventmesh-meta-nacos/src/main/java/org/apache/eventmesh/meta/nacos/service/NacosMetaService.java:
##########
@@ -242,16 +277,67 @@ public void registerMetadata(Map<String, String>
metadataMap) {
}
}
+ // implement with http
@Override
- public String getMetaData(String key) {
- try {
- return this.nacosConfigService.getConfig(key, group, 5000L);
- } catch (NacosException e) {
+ public Map<String, String> getMetaData(String key, boolean fuzzyEnabled) {
+ if (fuzzyEnabled) {
+ key = key + "*";
+ }
+ int pageNo = 1;
+ int pageSize = 100;
Review Comment:
These two parameters are currently only used for fuzzy queries in nacos. I
am not sure whether they will be used for other components, so I have not made
any modifications at the api layer to supplement these two parameters. If they
are used in other extended implementations later If needed, the parameters can
be extended to the api layer.
---
这两个参数目前只是nacos中的模糊查询时有用到，其他的组件我还不确定是否会用到，因此我没有在api层做修改补充这两个参数，如果后续在其他的扩展实现中也需要用到，可以将参数扩展到api层。
##########
eventmesh-meta/eventmesh-meta-nacos/src/main/java/org/apache/eventmesh/meta/nacos/service/NacosMetaService.java:
##########
@@ -242,16 +277,67 @@ public void registerMetadata(Map<String, String>
metadataMap) {
}
}
+ // implement with http
@Override
- public String getMetaData(String key) {
- try {
- return this.nacosConfigService.getConfig(key, group, 5000L);
- } catch (NacosException e) {
+ public Map<String, String> getMetaData(String key, boolean fuzzyEnabled) {
+ if (fuzzyEnabled) {
+ key = key + "*";
+ }
+ int pageNo = 1;
+ int pageSize = 100;
Review Comment:
These two parameters are currently only used for fuzzy queries in nacos. I
am not sure whether they will be used for other components, so I have not made
any modifications at the api layer to supplement these two parameters. If they
are used in other extended implementations later If needed, the parameters can
be extended to the api layer.
---
这两个参数目前只是nacos中的模糊查询时有用到，其他的组件我还不确定是否会用到，因此我没有在api层做修改补充这两个参数，如果后续在其他的扩展实现中也需要用到，可以将参数扩展到api层。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
