pandaapo commented on code in PR #4582:
URL: https://github.com/apache/eventmesh/pull/4582#discussion_r1407056808
##########
eventmesh-metrics-plugin/eventmesh-metrics-prometheus/src/main/java/org/apache/eventmesh/metrics/prometheus/utils/PrometheusExporterUtils.java:
##########
@@ -70,7 +70,7 @@ public static <T extends Metric> void observeOfValue(Meter
meter, String metricN
* @return
*/
public static String[] join(String metricName, String desc) {
- return new String[] {metricName, desc};
+ return new String[]{metricName, desc};
Review Comment:
> because the previous developer did not execute checkstyle, resulting in
spotless not being processed successfully.
I don't understand. Isn't the execution of checkstyle and the spotless
independent of each other?
没明白。checkstyle的执行和spotless不是相互独立的吗？
> Checkstyle is a more relaxed requirement, and spotless will do more
detailed formatting.
Is there a way to make the format requirements of the two consistent?
有没有办法让两者的格式要求一致？
##########
eventmesh-metrics-plugin/eventmesh-metrics-prometheus/src/main/java/org/apache/eventmesh/metrics/prometheus/utils/PrometheusExporterUtils.java:
##########
@@ -70,7 +70,7 @@ public static <T extends Metric> void observeOfValue(Meter
meter, String metricN
* @return
*/
public static String[] join(String metricName, String desc) {
- return new String[] {metricName, desc};
+ return new String[]{metricName, desc};
Review Comment:
> because the previous developer did not execute checkstyle, resulting in
spotless not being processed successfully.
I don't understand. Isn't the execution of checkstyle and the spotless
independent of each other?
没明白。checkstyle的执行和spotless不是相互独立的吗？
> Checkstyle is a more relaxed requirement, and spotless will do more
detailed formatting.
Is there a way to make the format requirements of the two consistent?
有没有办法让两者的格式要求一致？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
