pandaapo commented on code in PR #4594: URL: https://github.com/apache/eventmesh/pull/4594#discussion_r1412786952
########## eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.connector.wechat.sink.connector; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.times; +import static org.mockito.Mockito.verify; + +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.List; +import okhttp3.Call; +import okhttp3.MediaType; +import okhttp3.Protocol; Review Comment: ``` 2023-12-02T05:10:42.0323270Z > Task :eventmesh-connectors:eventmesh-connector-wechat:checkstyleMain 2023-12-02T05:10:42.3737160Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:27:1: 'okhttp3.Call' should be separated from previous imports. [ImportOrder] 2023-12-02T05:10:42.3740770Z 2023-12-02T05:10:42.3747510Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:30:1: Wrong order for 'org.apache.eventmesh.connector.wechat.sink.config.WeChatSinkConfig' import. [ImportOrder] 2023-12-02T05:10:42.3751510Z > Task :eventmesh-connectors:eventmesh-connector-wechat:checkstyleTest FAILED 2023-12-02T05:10:42.3755240Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:35:1: 'org.junit.jupiter.api.BeforeEach' should be separated from previous imports. [ImportOrder] 2023-12-02T05:10:42.3760840Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:50:1: Wrong order for 'java.lang.reflect.Field' import. [ImportOrder] 2023-12-02T05:10:42.3810020Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:64:9: Distance between variable 'weChatSinkConfig' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value). [VariableDeclarationUsageDistance] 2023-12-02T05:10:42.4728570Z [ant:checkstyle] [WARN] /Users/runner/work/eventmesh/eventmesh/eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:91: Line is longer than 150 characters (found 152). [LineLength] ``` These are checkstyle errors. ``` Dependencies check failed, please check if you add known dependencies Error: Process completed with exit code 1. ``` You need to add com.squareup.okhttp3:okhttp:4.10.0 to eventmesh/tools/dependency-check/known-dependencies.txt. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
