pandaapo commented on code in PR #4603:
URL: https://github.com/apache/eventmesh/pull/4603#discussion_r1415654866
##########
eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:
##########
@@ -95,31 +109,43 @@ public void setUp() throws Exception {
Mockito.doReturn(sendMessageRequestCall).when(okHttpClient).newCall(Mockito.argThat(sendMessageMatcher));
Mockito.doReturn(sendMessageResponse).when(sendMessageRequestCall).execute();
- weChatSinkConnector = new WeChatSinkConnector();
- WeChatSinkConfig weChatSinkConfig = (WeChatSinkConfig)
ConfigUtil.parse(weChatSinkConnector.configClass());
- weChatSinkConnector.init(weChatSinkConfig);
- Field clientField =
ReflectionSupport.findFields(weChatSinkConnector.getClass(),
- (f) -> f.getName().equals("okHttpClient"),
- HierarchyTraversalMode.BOTTOM_UP).get(0);
- clientField.setAccessible(true);
- clientField.set(weChatSinkConnector, okHttpClient);
- weChatSinkConnector.start();
+ List<ConnectRecord> records = new ArrayList<>();
+ RecordPartition partition = new RecordPartition();
+ RecordOffset offset = new RecordOffset();
+ ConnectRecord connectRecord = new ConnectRecord(partition, offset,
+ System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
+ records.add(connectRecord);
+
+ weChatSinkConnector.put(records);
+ verify(okHttpClient, times(2)).newCall(any(Request.class));
}
@Test
- public void testSendMessageToWeChat() throws Exception {
- final int times = 1;
- List<ConnectRecord> records = new ArrayList<>();
- for (int i = 0; i < times; i++) {
- RecordPartition partition = new RecordPartition();
- RecordOffset offset = new RecordOffset();
- ConnectRecord connectRecord = new ConnectRecord(partition, offset,
- System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
- records.add(connectRecord);
- }
+ public void testSendMessageToWeChatAbnormally() throws Exception {
+ Request sendMessageRequest = new
Request.Builder().url("https://api.weixin.qq.com/cgi-bin/message/template/send";).build();
+ String sendMessageResponseJson =
"{\"errcode\":42001,\"errmsg\":\"access_token expired rid:
656e8793-061949b5-738cb8f4\"}";
+ ResponseBody sendMessageBody =
ResponseBody.create(MediaType.parse("application/json; charset=utf-8"),
sendMessageResponseJson);
+ Response sendMessageResponse = new Response.Builder()
+ .code(200)
+ .protocol(Protocol.HTTP_1_0)
+ .request(sendMessageRequest)
+ .body(sendMessageBody)
+ .message("ok")
+ .build();
+ ArgumentMatcher<Request> sendMessageMatcher = (anyRequest) ->
+
sendMessageRequest.url().encodedPath().startsWith(anyRequest.url().encodedPath());
+ Call sendMessageRequestCall = Mockito.mock(Call.class);
+
Mockito.doReturn(sendMessageRequestCall).when(okHttpClient).newCall(Mockito.argThat(sendMessageMatcher));
+
Mockito.doReturn(sendMessageResponse).when(sendMessageRequestCall).execute();
+ RecordPartition partition = new RecordPartition();
+ RecordOffset offset = new RecordOffset();
+ List<ConnectRecord> records = new ArrayList<>();
+ ConnectRecord connectRecord = new ConnectRecord(partition, offset,
+ System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
+ records.add(connectRecord);
weChatSinkConnector.put(records);
- verify(okHttpClient, times(times + 1)).newCall(any(Request.class));
+ verify(okHttpClient, times(2)).newCall(any(Request.class));
Review Comment:
> i used reflect api to invoke the weChatSinkConnector.sendMessage() and
then throw InvocationTargetException, IllegalAccessException has been transfer
to InvocationTargetException, ... i think it looks a little strange
It may seem a bit strange, but I don't have a better idea at the moment. I
personally disagree with PowerMockito, as it is not as restrained as Mockito,
but it's just my personal opinion. You can choose to use reflection,
PowerMockito, or directly test the put () exception to indirectly test the
sendMessage () exception.
确实这样会有点奇怪，但是我目前也没有更好的主意。对于PowerMockito，我个人不太认同，它不像Mockito更加克制，但只是我个人观点。您可以自己选择使用反射，或者PowerMockito，或者直接测试put()异常情况来间接测试sendMessage()异常情况。
##########
eventmesh-connectors/eventmesh-connector-wechat/src/test/java/org/apache/eventmesh/connector/wechat/sink/connector/WeChatSinkConnectorTest.java:
##########
@@ -95,31 +109,43 @@ public void setUp() throws Exception {
Mockito.doReturn(sendMessageRequestCall).when(okHttpClient).newCall(Mockito.argThat(sendMessageMatcher));
Mockito.doReturn(sendMessageResponse).when(sendMessageRequestCall).execute();
- weChatSinkConnector = new WeChatSinkConnector();
- WeChatSinkConfig weChatSinkConfig = (WeChatSinkConfig)
ConfigUtil.parse(weChatSinkConnector.configClass());
- weChatSinkConnector.init(weChatSinkConfig);
- Field clientField =
ReflectionSupport.findFields(weChatSinkConnector.getClass(),
- (f) -> f.getName().equals("okHttpClient"),
- HierarchyTraversalMode.BOTTOM_UP).get(0);
- clientField.setAccessible(true);
- clientField.set(weChatSinkConnector, okHttpClient);
- weChatSinkConnector.start();
+ List<ConnectRecord> records = new ArrayList<>();
+ RecordPartition partition = new RecordPartition();
+ RecordOffset offset = new RecordOffset();
+ ConnectRecord connectRecord = new ConnectRecord(partition, offset,
+ System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
+ records.add(connectRecord);
+
+ weChatSinkConnector.put(records);
+ verify(okHttpClient, times(2)).newCall(any(Request.class));
}
@Test
- public void testSendMessageToWeChat() throws Exception {
- final int times = 1;
- List<ConnectRecord> records = new ArrayList<>();
- for (int i = 0; i < times; i++) {
- RecordPartition partition = new RecordPartition();
- RecordOffset offset = new RecordOffset();
- ConnectRecord connectRecord = new ConnectRecord(partition, offset,
- System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
- records.add(connectRecord);
- }
+ public void testSendMessageToWeChatAbnormally() throws Exception {
+ Request sendMessageRequest = new
Request.Builder().url("https://api.weixin.qq.com/cgi-bin/message/template/send";).build();
+ String sendMessageResponseJson =
"{\"errcode\":42001,\"errmsg\":\"access_token expired rid:
656e8793-061949b5-738cb8f4\"}";
+ ResponseBody sendMessageBody =
ResponseBody.create(MediaType.parse("application/json; charset=utf-8"),
sendMessageResponseJson);
+ Response sendMessageResponse = new Response.Builder()
+ .code(200)
+ .protocol(Protocol.HTTP_1_0)
+ .request(sendMessageRequest)
+ .body(sendMessageBody)
+ .message("ok")
+ .build();
+ ArgumentMatcher<Request> sendMessageMatcher = (anyRequest) ->
+
sendMessageRequest.url().encodedPath().startsWith(anyRequest.url().encodedPath());
+ Call sendMessageRequestCall = Mockito.mock(Call.class);
+
Mockito.doReturn(sendMessageRequestCall).when(okHttpClient).newCall(Mockito.argThat(sendMessageMatcher));
+
Mockito.doReturn(sendMessageResponse).when(sendMessageRequestCall).execute();
+ RecordPartition partition = new RecordPartition();
+ RecordOffset offset = new RecordOffset();
+ List<ConnectRecord> records = new ArrayList<>();
+ ConnectRecord connectRecord = new ConnectRecord(partition, offset,
+ System.currentTimeMillis(), "Hello,
EventMesh!".getBytes(StandardCharsets.UTF_8));
+ records.add(connectRecord);
weChatSinkConnector.put(records);
- verify(okHttpClient, times(times + 1)).newCall(any(Request.class));
+ verify(okHttpClient, times(2)).newCall(any(Request.class));
Review Comment:
> i used reflect api to invoke the weChatSinkConnector.sendMessage() and
then throw InvocationTargetException, IllegalAccessException has been transfer
to InvocationTargetException, ... i think it looks a little strange
It may seem a bit strange, but I don't have a better idea at the moment. I
personally disagree with PowerMockito, as it is not as restrained as Mockito,
but it's just my personal opinion. You can choose to use reflection,
PowerMockito, or directly test the put () exception to indirectly test the
sendMessage () exception.
确实这样会有点奇怪，但是我目前也没有更好的主意。对于PowerMockito，我个人不太认同，它不像Mockito更加克制，但只是我个人观点。您可以自己选择使用反射，或者PowerMockito，或者直接测试put()异常情况来间接测试sendMessage()异常情况。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
