pandaapo commented on PR #4640: URL: https://github.com/apache/eventmesh/pull/4640#issuecomment-1854925678
> > @HarshSawarkar cool bro. :) 😎 But why that file is being shown as deleted now? It should not be present entirely in your commit. > > I don't know I tried to roll back changes but the file remain intacted so I deleted it. @HarshSawarkar @VishalMCF Because this branch was created based on the branch of #4636, there were modifications and deletion of `EtcdMetaService` that should not have occurred. If this PR is merged, `EtcdMetaService` in the source code will be deleted. This is not right. You should create a development branch based on the latest master branch that is consistent with the source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
