pandaapo commented on code in PR #4653:
URL: https://github.com/apache/eventmesh/pull/4653#discussion_r1427592935


##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java:
##########
@@ -93,27 +96,26 @@ public void init() {
         heartBeat();
     }
 
+    /**
+     * Subscribes to an event at a specified URL(Webhook).
+     *
+     * @param subscriptionItems The list of subscription items.
+     * @param url               The URL to subscribe to.
+     * @return A response containing information about the subscription result.
+     */
     public Response subscribe(final List<SubscriptionItem> subscriptionItems, 
final String url) {

Review Comment:
   > when there is no stream subscription, it is necessary to switch to a 
heartbeating method to resolve the issue.
   
   Thank you for your answer. What does this sentence mean? Is it true that 
heartBeat() is only used for non stream subscriptions (webhook), and its effect 
is not significant when normal subscriptions are in progress?
   
   感谢您的解答。这句是什么意思?是说“heartBeat()只是用于非流的方式订阅(webhook),流方式订阅时该heartBeat()其实作用不大”吗?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to