xwm1992 commented on code in PR #4655:
URL: https://github.com/apache/eventmesh/pull/4655#discussion_r1428769297
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/IPUtils.java:
##########
@@ -76,7 +81,7 @@ public static String getLocalAddress() {
ArrayList<String> ipv4Result = new ArrayList<String>();
ArrayList<String> ipv6Result = new ArrayList<String>();
- if (preferNetworkInterface != null) {
+ if (preferNetworkInterface != null && matchName) {
Review Comment:
> @xwm1992 The modifications in this PR do not break the original logic, and
they can also help some users avoid the trouble of manually changing jvm
parameters and reduce the usage barriers. Is it appropriate to view this PR in
this way?
I think the modified content of this pr is inconsistent with the described
problem. You only need to configure the jvm parameters to adjust whether to use
ipv4. There is no need to add `match` to judge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
