pandaapo commented on code in PR #4591:
URL: https://github.com/apache/eventmesh/pull/4591#discussion_r1428812499
##########
eventmesh-connectors/eventmesh-connector-dingtalk/src/main/java/org/apache/eventmesh/connector/dingtalk/config/DingDingMessageTemplateType.java:
##########
@@ -21,23 +21,30 @@
public enum DingDingMessageTemplateType {
- PLAIN_TEXT("sampleText"),
- MARKDOWN("sampleMarkdown");
+ PLAIN_TEXT("text", "sampleText"),
+ MARKDOWN("markdown", "sampleMarkdown");
Review Comment:
> This issue is duplicated with #4601. I will provide a PR to fix this issue
in #4601 .
@yanrongzhen
The documents
([dingtalk](https://github.com/apache/eventmesh/blob/master/eventmesh-connectors/eventmesh-connector-dingtalk/README.md),
[wecom](https://github.com/apache/eventmesh/blob/master/eventmesh-connectors/eventmesh-connector-wecom/README.md))
you wrote did not inform the user which attribute values are valid. It will be
appreciate if you can supplement them later.
您写的文档（[钉钉](https://github.com/apache/eventmesh/blob/master/eventmesh-connectors/eventmesh-connector-dingtalk/README_CN.md),
[企业微信](https://github.com/apache/eventmesh/blob/master/eventmesh-connectors/eventmesh-connector-wecom/README_CN.md)）中并没有告知用户哪些属性值是合法的，希望您后期能进行补充。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
