Pil0tXia commented on code in PR #4679:
URL: https://github.com/apache/eventmesh/pull/4679#discussion_r1431118403
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/configuration/EventMeshTCPConfiguration.java:
##########
@@ -59,7 +59,28 @@ public class EventMeshTCPConfiguration extends
CommonConfiguration {
private int eventMeshTcpGlobalScheduler = 5;
@ConfigFiled(field = "tcp.taskHandleExecutorPoolSize")
- private int eventMeshTcpTaskHandleExecutorPoolSize =
Runtime.getRuntime().availableProcessors();
+ private int eventMeshTcpTaskHandleExecutorPoolSize = 2 *
Runtime.getRuntime().availableProcessors();
+
+ @ConfigFiled(field = "tcp.sendExecutorPoolSize")
+ private int eventMeshTcpMsgSendExecutorPoolSize = 2 *
Runtime.getRuntime().availableProcessors();
+
+ @ConfigFiled(field = "tcp.replyExecutorPoolSize")
+ private int eventMeshTcpMsgReplyExecutorPoolSize = 2 *
Runtime.getRuntime().availableProcessors();
+
+ @ConfigFiled(field = "tcp.ackExecutorPoolSize")
+ private int eventMeshTcpMsgAckExecutorPoolSize = 2 *
Runtime.getRuntime().availableProcessors();
+
Review Comment:
Although this is an IO-intensive scenario, with the original single thread
pool being split into four, and each thread pool having twice the coreSize as
before, the number of threads is 8 times the original. Considering that the
1-RTT time in EventMesh is relatively short, I suggest setting the `coreSize`
of each thread pool to the number of physical CPU cores and the `maxSize` to
double that. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
