Pil0tXia commented on code in PR #4673:
URL: https://github.com/apache/eventmesh/pull/4673#discussion_r1431188321
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/ThreadPoolFactory.java:
##########
@@ -41,13 +41,13 @@ public static ThreadPoolExecutor
createThreadPoolExecutor(int core, int max, fin
public static ThreadPoolExecutor createThreadPoolExecutor(int core, int
max, BlockingQueue<Runnable> blockingQueue,
final String threadName, final boolean isDaemon) {
- return new ThreadPoolExecutor(core, max, 10 * 1000,
TimeUnit.MILLISECONDS, blockingQueue,
+ return new LogThreadPoolExecutor(core, max, 10 * 1000,
TimeUnit.MILLISECONDS, blockingQueue,
Review Comment:
These two `createThreadPoolExecutor` methods are used by
`EventMeshGrpcServer` and `HTTPThreadPoolGroup`. Why their return type should
be changed to `LogThreadPoolExecutor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
