mxsm commented on PR #4702: URL: https://github.com/apache/eventmesh/pull/4702#issuecomment-1873302447
> > When the TCP-sent data packet is not sufficient to construct a Package, it will result in an error. If using a custom approach, you need to handle the issues of packet fragmentation and incomplete packets. The previously merged TCP enhancement pull request did not address this, and there would be no issue if packet fragmentation and incomplete packets did not occur. > > Thanks for your explanation. So your PR essentially moves the logic of `Codec.EnCoder` and `Codec.Decoder` into `Codec`. This raises a new question for me: in the data packet processing for message stickiness and message truncation in the encoding and decoding logic of `Codec`, what is the difference between calling the internal class object and handling it directly? > > 谢谢您的说明。所以您的PR相当于将`Codec.EnCoder`和`Codec.Decoder`的逻辑移到了`Codec`中。这让我产生了新的疑问，在`Codec`编解码逻辑中，调用内部类对象处理数据粘包、半包问题的方式和直接处理的方式，有什么不同？ The functional code of encoding has not changed; only the positions were replaced. The decoding code has been repaired to address the issues of packet fragmentation and incomplete packets. It's not just a simple code move. You can compare it with the previous code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
