tylerbertrand commented on PR #4689: URL: https://github.com/apache/eventmesh/pull/4689#issuecomment-1873549078
Hi @yanrongzhen. Jumping in for @samotleriche here - we definitely understand if you don't want to change the current behavior of executing `spotlessApply` during a build. It is indeed a bit of a process change. Our other optimizations - enabling caching, and limiting spotless to just the src java files - will still have a positive impact on build times. To quantify the impact of continuing to run `spotlessApply` on every `build`... With the improperly formatted code currently committed to `master`, [here is a build scan](https://ge.solutions-team.gradle.com/s/uno2ij2h4csgw/timeline?collapse-all&outcome=success&view=by-type) showing all the tasks that re-run needlessly if we keep the `checkstyleMain` dependency on `spotlessApply`. This will happen to some degree any time a developer makes a code change that is not properly formatted and runs a `build` - `spotlessApply` will format the code, and on the subsequent build, compilation, tests, etc. will all re-run even if no further changes were made by the developer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
