Pil0tXia commented on code in PR #4713:
URL: https://github.com/apache/eventmesh/pull/4713#discussion_r1440132545
##########
eventmesh-meta/eventmesh-meta-nacos/src/main/java/org/apache/eventmesh/meta/nacos/service/NacosMetaService.java:
##########
@@ -216,13 +216,25 @@ public void shutdown() throws MetaException {
if (!startStatus.compareAndSet(true, false)) {
return;
}
+ shutdownNacosService();
+ }
+
+ @SuppressWarnings("checkstyle:WhitespaceAround")
Review Comment:
Why CheckStyle warnings should be suppressed?
##########
eventmesh-meta/eventmesh-meta-nacos/src/main/java/org/apache/eventmesh/meta/nacos/service/NacosMetaService.java:
##########
@@ -216,13 +216,25 @@ public void shutdown() throws MetaException {
if (!startStatus.compareAndSet(true, false)) {
return;
}
+ shutdownNacosService();
Review Comment:
I think this method can be inlined. The `shutdown()` interface is used to
shutdown Nacos, and there is no need to extract a separate method specifically
for closing Nacos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
