Pil0tXia commented on code in PR #4693:
URL: https://github.com/apache/eventmesh/pull/4693#discussion_r1447119867


##########
eventmesh-operator/config/samples/eventmesh_v1_connectors_rocketmq.yaml:
##########
@@ -86,11 +86,11 @@ spec:
       # resources describes the compute resource requirements and limits
       resources:
         requests:
-          memory: "512Mi"
-          cpu: "250m"
+          memory: 512Mi
+          cpu: 250m
         limits:
-          memory: "1024Mi"
-          cpu: "500m"
+          memory: 1024Mi
+          cpu: 500m

Review Comment:
   The RocketMQ connector is a single-threaded application, which means it has 
limited consumption speed. It operates in scenarios where network I/O is 
dominant. In theory, it would require a maximum of 1 CPU when there is a sudden 
surge of messages from the upstream. I'm not sure if 0.5 CPU is sufficient. 
Could you please set the limit to 1 CPU or higher and use the "kubectl top pod" 
command to check the maximum CPU usage when the connector consumes messages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to