clayburn commented on code in PR #4740:
URL: https://github.com/apache/eventmesh/pull/4740#discussion_r1450720494
##########
.github/workflows/ci.yml:
##########
@@ -33,29 +33,12 @@ jobs:
matrix:
os: [ ubuntu-latest, macOS-latest ]
java: [ 8, 11 ]
- language: ['java', 'go']
runs-on: ${{ matrix.os }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
- - name: Initialize CodeQL
- uses: github/codeql-action/init@v2
- with:
- # If you wish to specify custom queries, you can do so here or in a
config file.
- # By default, queries listed here will override any specified in a
config file.
- # Prefix the list here with "+" to use these queries and those in
the config file.
- # queries: ./path/to/local/query, your-org/your-repo/queries@main
- languages: ${{ matrix.language }}
-
- - if: matrix.language == 'cpp' || matrix.language == 'csharp'
Review Comment:
> You mean L52~L57 task
Yes, the conditional check for cpp/csharp
> Build C task was added in https://github.com/apache/eventmesh/pull/4543.
It seems intentional to skip the Build C task, and there is further room for
optimization (such as submodules: true not added yet) in this area. We have Git
submodules in our C SDK, and we want to test these C codes.
I'm not quite sure what you mean here, since the way this is currently
authored, matrix.language will never be either of these two options. So this is
essentially a dead code path as it exists today. But I can add it back if it is
an area of future change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
