Pil0tXia commented on code in PR #4741:
URL: https://github.com/apache/eventmesh/pull/4741#discussion_r1450981368
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/constants/EventMeshConstants.java:
##########
@@ -152,11 +152,15 @@ public class EventMeshConstants {
public static final String MESSAGE = "message";
public static final String CMD = "cmd";
public static final String ACL = "acl";
+ public static final String BATCH_MSG = "batchMessage";
public static final String MSG_TYPE = "msgtype";
public static final String PERSISTENT = "persistent";
public static final String HANDLER_ORIGIN = "Access-Control-Allow-Origin";
public static final String HANDLER_METHODS =
"Access-Control-Allow-Methods";
public static final String HANDLER_HEADERS =
"Access-Control-Allow-Headers";
public static final String HANDLER_AGE = "Access-Control-Max-Age";
public static final String MAX_AGE = "86400";
+
+ public static final String TCP_MONITOR = "tcpMonitor";
+ public static final String APP_MONITOR = "appMonitor";
}
Review Comment:
How about combining TCP_MONITOR, APP_MONITOR, and BATCH_MSG together?
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java:
##########
@@ -67,11 +67,11 @@
public class BatchSendMessageProcessor implements HttpRequestProcessor {
- private final Logger cmdLogger =
LoggerFactory.getLogger(EventMeshConstants.CMD);
+ private static final Logger CMD_LOGGER =
LoggerFactory.getLogger(EventMeshConstants.CMD);
- private final Logger aclLogger =
LoggerFactory.getLogger(EventMeshConstants.ACL);
+ private static final Logger ACL_LOGGER =
LoggerFactory.getLogger(EventMeshConstants.ACL);
- private final Logger batchMessageLogger =
LoggerFactory.getLogger("batchMessage");
+ private static final Logger BATCH_MESSAGE_LOGGER =
LoggerFactory.getLogger(EventMeshConstants.BATCH_MSG);
Review Comment:
Perhaps `BATCH_MSG_LOGGER` will correspond better with `BATCH_MSG` constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
