Pil0tXia commented on code in PR #4746:
URL: https://github.com/apache/eventmesh/pull/4746#discussion_r1453712701
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/client/impl/PubClientImpl.java:
##########
@@ -73,7 +73,7 @@ public void close() {
task.cancel(false);
super.close();
} catch (Exception e) {
- e.printStackTrace();
+ log.error("Error occured during close operation",e);
}
Review Comment:
Please refer to the format of the example I provided in the issue for
recording the log:
Regarding the 4 pull requests you submitted for issue #4733, we will only
merge one. Please consolidate the changes into a single pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
