Pil0tXia commented on code in PR #4752:
URL: https://github.com/apache/eventmesh/pull/4752#discussion_r1460389190
##########
eventmesh-meta/eventmesh-meta-etcd/src/main/java/org/apache/eventmesh/meta/etcd/service/EtcdCustomService.java:
##########
@@ -67,6 +67,9 @@ public List<EventMeshServicePubTopicInfo>
findEventMeshServicePubTopicInfos() th
return eventMeshServicePubTopicInfoList;
}
} catch (Exception e) {
+ if (e instanceof InterruptedException) {
+ Thread.currentThread().interrupt();
+ }
log.error("[EtcdRegistryService][findEventMeshServicePubTopicInfos] error", e);
throw new MetaException(e.getMessage());
}
Review Comment:
Please catch `InterruptedException` in a separate `catch` code block instead
of judging it. You may see
`org.apache.eventmesh.meta.etcd.service.EtcdMetaService` L173-175 and L300-302
for examples.
https://github.com/apache/eventmesh/blob/21e4c3a36816576de7eec903c885cf6e5f956c31/eventmesh-meta/eventmesh-meta-etcd/src/main/java/org/apache/eventmesh/meta/etcd/service/EtcdMetaService.java#L173-L179
https://github.com/apache/eventmesh/blob/21e4c3a36816576de7eec903c885cf6e5f956c31/eventmesh-meta/eventmesh-meta-etcd/src/main/java/org/apache/eventmesh/meta/etcd/service/EtcdMetaService.java#L298-L305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
