Pil0tXia commented on code in PR #19:
URL:
https://github.com/apache/eventmesh-dashboard/pull/19#discussion_r1461094324
##########
pom.xml:
##########
@@ -78,6 +78,8 @@
<maven.compiler.source>8</maven.compiler.source>
<maven.compiler.target>8</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <spring-boot.version>2.7.6</spring-boot.version>
+ <mybatis-spring-boot.version>2.1.4</mybatis-spring-boot.version>
</properties>
Review Comment:
This version is outdated.
##########
eventmesh-dashboard-console/src/main/resources/logback.xml:
##########
@@ -0,0 +1,50 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<configuration>
+ <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
+ <encoder charset="UTF-8">
+ <pattern>[%d{yyyy-MM-dd HH:mm:ss.SSS}] %p %t - %m%n</pattern>
+ </encoder>
+ </appender>
+
+ <appender name="FILE"
+ class="ch.qos.logback.core.rolling.RollingFileAppender">
+ <file>${user.home}/logs/eventmesh-dashboard-console.log</file>
+ <append>true</append>
+ <rollingPolicy
class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
+
<fileNamePattern>${user.home}/logs/eventmesh-dashboard-console-%d{yyyy-MM-dd}.%i.log
+ </fileNamePattern>
Review Comment:
`eventmesh-dashboard` instead of `eventmesh-dashboard-console`.
##########
eventmesh-dashboard-console/pom.xml:
##########
@@ -32,10 +37,16 @@
<version>1.7.0</version>
</dependency>
- <!-- dashboard.core dependency -->
+ <!-- eventmesh.dashboard dependency -->
+ <dependency>
+ <groupId>org.apache.eventmesh.dashboard.common</groupId>
+ <artifactId>eventmesh-dashboard-common</artifactId>
+ <version>0.0.1-SNAPSHOT</version>
+ <scope>compile</scope>
+ </dependency>
Review Comment:
L45 is redundant.
##########
eventmesh-dashboard-console/src/main/resources/application-dev.yml:
##########
@@ -29,37 +29,23 @@ spring:
name: eventmesh-console
datasource:
name: eventmesh-console
- url:
jdbc:mysql://${EVENTMESH_CONSOLE_DB_HOST}/eventmesh-dashboard?useSSL=false&useUnicode=true&characterEncoding=utf-8&allowMultiQueries=true&zeroDateTimeBehavior=convertToNull&allowPublicKeyRetrieval=true
- username: ${EVENTMESH_CONSOLE_DB_USERNAME}
- password: ${EVENTMESH_CONSOLE_DB_PASSWORD}
- # using druid data source
type: com.alibaba.druid.pool.DruidDataSource
- driver-class-name: com.mysql.cj.jdbc.Driver
- maxActive: 20
- initialSize: 1
- maxWait: 60000
- minIdle: 1
- timeBetweenEvictionRunsMillis: 60000
- minEvictableIdleTimeMillis: 300000
- validationQuery: select 'x'
- testWhileIdle: true
- testOnBorrow: false
- testOnReturn: false
- poolPreparedStatements: true
- maxOpenPreparedStatements: 20
- # encrypt password
- filters: config
+ druid:
+ driver-class-name: com.mysql.cj.jdbc.Driver
+ url:
jdbc:mysql://localhost/eventmesh-dashboard?useSSL=false&useUnicode=true&characterEncoding=utf-8&allowMultiQueries=true&zeroDateTimeBehavior=convertToNull&allowPublicKeyRetrieval=true
Review Comment:
The db port number is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
