mxsm commented on code in PR #4757:
URL: https://github.com/apache/eventmesh/pull/4757#discussion_r1465763641
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java:
##########
@@ -66,12 +66,46 @@ public Map<String, Object> toMap() {
return map;
}
- @ToString
+ @Data
public static class HeartbeatEntity {
- public String topic;
- public String serviceId;
- public String url;
- public String instanceId;
+ private String topic;
+ private String serviceId;
+ private String url;
+ private String instanceId;
+
+ public String getTopic() {
+ return topic;
+ }
+
+ public void setTopic(String topic) {
+ this.topic = topic;
+ }
+
+ public String getServiceId() {
+ return serviceId;
+ }
+
+ public void setServiceId(String serviceId) {
+ this.serviceId = serviceId;
+ }
+
+ public String getUrl() {
+ return url;
+ }
+
+ public void setUrl(String url) {
+ this.url = url;
+ }
+
+ public String getInstanceId() {
+ return instanceId;
+ }
+
+ public void setInstanceId(String instanceId) {
+ this.instanceId = instanceId;
+ }
Review Comment:
This code is unnecessary. because you has used the `@Data` annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
