Pil0tXia commented on code in PR #4739: URL: https://github.com/apache/eventmesh/pull/4739#discussion_r1472957496
########## eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshAdminBootstrap.java: ########## @@ -17,34 +17,28 @@ package org.apache.eventmesh.runtime.boot; -import org.apache.eventmesh.runtime.admin.controller.HttpHandlerManager; +import org.apache.eventmesh.runtime.admin.controller.ClientManageController; import org.apache.eventmesh.runtime.configuration.EventMeshHTTPConfiguration; Review Comment: I feel that referencing `ClientManageController` in `EventMeshAdminBootstrap` is not a good practice. I think the design of `ClientManageController` and `HttpHandlerManager` has been outdated and it will be great if you may redesign them to fit EventMesh style of Netty HTTP Server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
