Pil0tXia commented on code in PR #4768:
URL: https://github.com/apache/eventmesh/pull/4768#discussion_r1547427620


##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/admin/handler/QueryRecommendEventMeshHandlerTest.java:
##########


Review Comment:
   May I ask why some unit tests have been removed? Is it because they are 
redundant?



##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/HttpCommand.java:
##########
@@ -66,6 +67,16 @@ public class HttpCommand implements ProtocolTransportObject {
     // Command response time
     public long resTime;
 
+    public URI requestURI;
+
+    public URI getRequestURI() {
+        return requestURI;
+    }
+
+    public void setRequestURI(URI requestURI) {
+        this.requestURI = requestURI;
+    }

Review Comment:
   This class has a `@Data` annotation, so it doesn't need getters and setters.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org

Reply via email to