Pil0tXia commented on code in PR #4768:
URL: https://github.com/apache/eventmesh/pull/4768#discussion_r1554140155
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/RedirectClientByIpPortHandler.java:
##########
@@ -72,76 +72,62 @@ public RedirectClientByIpPortHandler(EventMeshTCPServer
eventMeshTCPServer) {
this.eventMeshTCPServer = eventMeshTCPServer;
}
- /**
- * Handles requests by redirecting matching clients to a target EventMesh
server node.
- *
- * @param httpExchange the exchange containing the request from the client
and used to send the response
- * @throws IOException if an I/O error occurs while handling the request
- */
@Override
- public void handle(HttpExchange httpExchange) throws IOException {
+ public void handle(HttpRequest httpRequest, ChannelHandlerContext ctx)
throws Exception {
String result = "";
- try (OutputStream out = httpExchange.getResponseBody()) {
- String queryString = httpExchange.getRequestURI().getQuery();
Review Comment:
May you please add the short description of JavaDoc back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org
