Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1554554264
##########
build.gradle:
##########
@@ -139,6 +164,72 @@ allprojects {
}
}
+def log4jVersion = '2.22.1'
+
+configurations {
+ distOnly
+}
+
+dependencies {
+ distOnly "org.apache.logging.log4j:log4j-core:${log4jVersion}"
+ distOnly "org.apache.logging.log4j:log4j-slf4j2-impl:${log4jVersion}"
+}
+
+tasks.register('dist') {
+ group = JavaBasePlugin.BUILD_TASK_NAME
+ description "Creates the distribution directory"
+ def includedProjects =
+ ["eventmesh-common",
+ "eventmesh-meta:eventmesh-meta-api",
+ "eventmesh-metrics-plugin:eventmesh-metrics-api",
+ "eventmesh-protocol-plugin:eventmesh-protocol-api",
+ "eventmesh-retry:eventmesh-retry-api",
+ "eventmesh-runtime",
+ "eventmesh-security-plugin:eventmesh-security-api",
+ "eventmesh-spi",
+ "eventmesh-starter",
+ "eventmesh-storage-plugin:eventmesh-storage-api",
+ "eventmesh-trace-plugin:eventmesh-trace-api",
+ "eventmesh-webhook:eventmesh-webhook-api",
+ "eventmesh-webhook:eventmesh-webhook-admin",
+ "eventmesh-webhook:eventmesh-webhook-receive"]
+ includedProjects.each { dependsOn("${it}:jar") }
+ outputs.dirs('dist/apps', 'dist/bin', 'dist/conf', 'dist/lib',
'dist/licenses')
Review Comment:
May I ask what these two lines are for? How did you come up with the idea of
creating these two lines, did the IDE prompt you? ☺️
I didn't understand the usage of `dependsOn("${it}:jar")`.
It seems `outputs.dirs` equals to `mkdirs()`, but I haven't found much
documents and examples proving that.
(A little too cautious with old but working scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org
