Pil0tXia commented on code in PR #88: URL: https://github.com/apache/eventmesh-dashboard/pull/88#discussion_r1554582850
########## eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/entity/config/DefaultConfigKey.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.dashboard.console.entity.config; + + +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.NoArgsConstructor; + +@NoArgsConstructor +@AllArgsConstructor +@Data +public class DefaultConfigKey { + + private String businessType; + + private String configName; + + +} Review Comment: 2 redundant lines here. ########## eventmesh-dashboard-console/pom.xml: ########## @@ -79,6 +79,48 @@ <scope>runtime</scope> </dependency> + <!-- health check client --> + <!-- EventMesh SDK --> +<!-- <dependency>--> Review Comment: Please be noted that these changes will conflict with https://github.com/apache/eventmesh-dashboard/pull/85 (including `MetadataServiceTypeEnum`, `MetadataTypeEnum` and more). I think that it will be better to make these changes in https://github.com/apache/eventmesh-dashboard/pull/85, so I will merge https://github.com/apache/eventmesh-dashboard/pull/85 first. ########## eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/modle/dto/config/DynamicGetConfigDTO.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.dashboard.console.modle.dto.config; + +import lombok.AllArgsConstructor; +import lombok.Data; +import lombok.NoArgsConstructor; + +@NoArgsConstructor +@AllArgsConstructor +@Data +public class DynamicGetConfigDTO { Review Comment: No need to add `Dynamic` in class name~ What do you think? ########## eventmesh-dashboard-console/src/main/java/org/apache/eventmesh/dashboard/console/service/registry/impl/RegistryDataServiceImpl.java: ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.dashboard.console.service.registry.impl; + +import org.apache.eventmesh.dashboard.console.entity.meta.MetaEntity; +import org.apache.eventmesh.dashboard.console.mapper.meta.MetaMapper; +import org.apache.eventmesh.dashboard.console.service.registry.RegistryDataService; + +import java.util.List; + +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.stereotype.Service; + +@Service +public class RegistryDataServiceImpl implements RegistryDataService { + + @Autowired + MetaMapper metaMapper; + + public List<MetaEntity> selectAll() { + return metaMapper.selectAll(); + } + + @Override + public List<Long> batchInsert(List<MetaEntity> metaEntities) { + return metaMapper.batchInsert(metaEntities); + } + + @Override + public Long insert(MetaEntity metaEntity) { + return metaMapper.insert(metaEntity); + } + + @Override + public void deActive(MetaEntity metaEntity) { + metaMapper.deActive(metaEntity); Review Comment: `deactivate` is a single word, so it should be `deactivate()` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
