Pil0tXia commented on code in PR #4821:
URL: https://github.com/apache/eventmesh/pull/4821#discussion_r1557569553
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/admin/handler/AdminHandlerManager.java:
##########
@@ -117,7 +117,7 @@ public void registerHttpHandler() {
eventMeshGrpcServer.getEventMeshGrpcConfiguration()));
}
- private void initHandler(HttpHandler httpHandler) {
+ public void initHandler(HttpHandler httpHandler) {
EventMeshHttpHandler eventMeshHttpHandler =
httpHandler.getClass().getAnnotation(EventMeshHttpHandler.class);
Review Comment:
Is it a good practice to change a private method's scope just because a test
class needs to call it? Maybe we can try to use Reflection.
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/async/CompleteHandler.java:
##########
@@ -22,6 +22,7 @@
*
* @param <T>
*/
+@FunctionalInterface
public interface CompleteHandler<T> {
Review Comment:
It seems that there's no lambda usage of this class. What does the addition
of this annotation bring?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
