Pil0tXia commented on PR #4837: URL: https://github.com/apache/eventmesh/pull/4837#issuecomment-2058490497
>I think these are two different concepts because they have fundamental differences. "payload server url" means "the url of the server that is ready to receive the payload data from the sink connector", which is the same concept as callbackUrl. Relevant practice can be found at https://docs.github.com/en/webhooks/using-webhooks/creating-webhooks. >Adding the client's callback address through the server's configuration file can also achieve this purpose. However, we cannot add the callback addresses of all possible clients to the configuration file. It depends on whether you want to add the callbackUrl when the sink connector is running, or configure the callbackUrl when the sink connector starts. The former way may be like this: https://help.smartling.com/hc/en-us/articles/1260805504109-Webhooks-and-Callbacks. For the sink connector, EventMesh will use the latter approach (which is the GitHub way, configure callbackUrl in settings). This is because the sink connector can be started at a low cost with multiple nodes, each responsible for delivering messages of one topic. If users want to edit configurations (including callbackUrl), another connector can be deployed in 10s. For the same sink connector, multiple callbackUrl can be configured as a list in YAML. Events sent to each callbackUrl are treated as one delivery. i.e., if the user configures 10 callbackUrls, for one event received by the sink connector, 10 deliveries will occur. But, the callbackUrl should not be sent to the event's delivery target, because the server always responds to the client's request address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
