Pil0tXia commented on code in PR #3881:
URL: https://github.com/apache/eventmesh/pull/3881#discussion_r1575620686
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/group/ClientSessionGroupMapping.java:
##########
@@ -56,13 +55,11 @@ public class ClientSessionGroupMapping {
private static final Logger SESSION_LOGGER =
LoggerFactory.getLogger("sessionLogger");
- private final ConcurrentHashMap<InetSocketAddress, Session> sessionTable =
new ConcurrentHashMap<>();
+ private final ConcurrentHashMap<String/*ip:port*/, Session> sessionTable =
new ConcurrentHashMap<>(64);
Review Comment:
May I ask that what's the main benefit of changing `InetSocketAddress` to
`String`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org
