Pil0tXia commented on code in PR #4862: URL: https://github.com/apache/eventmesh/pull/4862#discussion_r1577783507
########## eventmesh-meta/eventmesh-meta-raft/src/main/java/org/apache/eventmesh/meta/raft/MetaService.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.eventmesh.meta.raft; + + +import org.apache.eventmesh.meta.raft.rpc.RequestResponse; + +/** + * MetaService. + */ +public interface MetaService { + + void handle(RequestResponse request, EventClosure closure); +} Review Comment: What is this interface used for? It has the same name with `org.apache.eventmesh.api.meta.MetaService` but only implemented by `org.apache.eventmesh.meta.raft.MetaServiceImpl`. How about renaming it or integrate it with `MetaServiceImpl`? ########## eventmesh-meta/eventmesh-meta-raft/build.gradle: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +plugins { + id 'java' + id 'com.google.protobuf' version '0.8.17' +} + +repositories { + mavenCentral() +} Review Comment: There's no need to add java plugin and mavenCentral in a subProject's buildscript. We have dependencyManagement in rootProject's buildscript. ########## eventmesh-runtime/conf/eventmesh.properties: ########## @@ -85,6 +85,14 @@ eventMesh.metaStorage.plugin.server-addr=127.0.0.1:8848 eventMesh.metaStorage.plugin.username=nacos eventMesh.metaStorage.plugin.password=nacos +# metaStorage plugin: raft +#eventMesh.metaStorage.raft.dataPath=/tmp/server1 +#eventMesh.metaStorage.raft.self=127.0.0.1:9091 +#eventMesh.metaStorage.raft.members=127.0.0.1:9092,127.0.0.1:9093 +#eventMesh.metaStorage.raft.electionTimeout=5 +#eventMesh.metaStorage.raft.snapshotInterval=30 +#eventMesh.metaStorage.raft.refreshLeaderInterval=3 + Review Comment: May you please leave a usage document/comment/URL that explains the meaning of these properties? ########## eventmesh-meta/eventmesh-meta-raft/build.gradle: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +plugins { + id 'java' + id 'com.google.protobuf' version '0.8.17' +} + +repositories { + mavenCentral() +} + +def grpcVersion = '1.43.2' // CURRENT_GRPC_VERSION Review Comment: The bundled grpc version of Jraft latest version 1.3.14 is `v1.50.2`, and it seems to be a safe version to upgrade. It will be better to use the same version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
