Pil0tXia commented on code in PR #4863:
URL: https://github.com/apache/eventmesh/pull/4863#discussion_r1578109036
##########
eventmesh-connectors/eventmesh-connector-jdbc/build.gradle:
##########
@@ -37,12 +37,12 @@ dependencies {
antlr("org.antlr:antlr4:4.13.0")
implementation 'org.antlr:antlr4-runtime:4.13.0'
implementation 'com.alibaba:druid:1.2.20'
- implementation 'org.hibernate:hibernate-core:5.6.15.Final'
+ compileOnly 'org.hibernate:hibernate-core:5.6.15.Final'
implementation project(":eventmesh-common")
implementation project(":eventmesh-openconnect:eventmesh-openconnect-java")
implementation project(":eventmesh-spi")
implementation 'com.zendesk:mysql-binlog-connector-java:0.28.0'
- implementation 'mysql:mysql-connector-java:8.0.32'
+ compileOnly 'mysql:mysql-connector-java:8.0.32'
Review Comment:
`mysql-connector-java` has been redirected to `mysql-connector-j`.
Although switching to `compileOnly` scope, its artifact jar package will
still be bundled in our binary distribution. Therefore we will have to remove
it manually before releasing, inform users to download its jar package, and put
the jar file into the `lib` directory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org
For additional commands, e-mail: issues-h...@eventmesh.apache.org
