Pil0tXia commented on code in PR #5102:
URL: https://github.com/apache/eventmesh/pull/5102#discussion_r1818332006
##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/config/connector/mq/kafka/SourceConnectorConfig.java:
##########
@@ -32,5 +32,4 @@ public class SourceConnectorConfig {
private String enableAutoCommit = "false";
private String sessionTimeoutMS = "10000";
private String maxPollRecords = "1000";
- private int pollTimeOut = 100;
}
Review Comment:
Can we allocate an appropriate timeout value for a source where we
anticipate the RT might be significantly slower, and override the global
default value?
If this feature isn't supported yet, you can implement it in a future PR.
This is very important for users who use multiple sources with the same
configuration files.
##########
eventmesh-sdks/eventmesh-sdk-c/third_party/curl:
##########
Review Comment:
Did the significant changes in these two git submodules come from upstream
updates? Are these changes compatible with our C SDK? If untested, it's
advisable not to update the versions of third-party dependencies, because the C
SDK cannot currently be tested in CI (since it cannot be compiled at the
moment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
