Pil0tXia commented on code in PR #199:
URL:
https://github.com/apache/eventmesh-dashboard/pull/199#discussion_r2083601158
##########
eventmesh-dashboard-common/pom.xml:
##########
@@ -30,20 +30,17 @@
<artifactId>eventmesh-dashboard-common</artifactId>
<properties>
- <java.version>1.8</java.version>
+ <java.version>17</java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
</properties>
<dependencies>
- <!-- TODO: common module should not contains spring framework,
considering remove this dependency -->
- <!-- Spring Boot Starter -->
<dependency>
- <groupId>org.springframework.boot</groupId>
- <artifactId>spring-boot-starter-web</artifactId>
- <scope>provided</scope>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-core</artifactId>
+ <version>5.1.19.RELEASE</version>
Review Comment:
Why we have to specify a spring-core version in `common` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
