Copilot commented on code in PR #221:
URL:
https://github.com/apache/eventmesh-dashboard/pull/221#discussion_r2639569156
##########
pom.xml:
##########
@@ -280,6 +280,24 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>1.6</version>
+ <configuration>
+ <!-- Use the GPG agent so passphrases are handled
securely by the agent/pinentry -->
+ <useAgent>true</useAgent>
+
+ <!--
+ Optional settings for environments where you
need a specific key, gpg executable,
+ or to enable loopback pinentry (useful for
some CI setups). Uncomment and set
+ only when required; prefer gpg-agent for
local/CI signing.
+ -->
+ <!-- <keyname>your-key-id-or-email</keyname> -->
+ <!-- <gpgExecutable>gpg</gpgExecutable> -->
+ <!--
+ <arguments>
+ <argument>--pinentry-mode</argument>
Review Comment:
The HTML entity encoding `--` is used instead of plain text `--` in
this XML comment. Since this is inside an XML comment block, you should use the
literal double dash `--` rather than HTML entities. The HTML entity encoding is
unnecessary here and makes the comment harder to read.
```suggestion
<argument>--pinentry-mode</argument>
```
##########
pom.xml:
##########
@@ -306,11 +324,11 @@
<distributionManagement>
<snapshotRepository>
<id>sonatype</id>
-
<url>https://s01.oss.sonatype.org/content/repositories/snapshots/</url>
+
<url>https://repository.apache.org/content/repositories/snapshots/</url>
</snapshotRepository>
<repository>
<id>sonatype</id>
Review Comment:
The repository ID "sonatype" is inconsistent with the actual repository URL
which points to Apache's repository. This ID should match the serverId
configured in the nexus-staging-maven-plugin (line 316) and should be renamed
to better reflect that it's an Apache repository rather than Sonatype.
##########
pom.xml:
##########
@@ -296,7 +314,7 @@
<extensions>true</extensions>
<configuration>
<serverId>sonatype</serverId>
Review Comment:
The serverId and repository IDs are still named "sonatype" but the URLs have
been changed to Apache's repository. This creates a naming inconsistency where
the identifier suggests Sonatype but the actual repository is Apache. Consider
renaming these IDs from "sonatype" to something more appropriate like "apache"
or "apache-repository" to better reflect the actual repository being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
