Github user iamrupok commented on the issue:
https://github.com/apache/fineract/pull/364
created a new pull request
#365
On Mon, Jun 12, 2017 at 11:26 AM, Shaik Nazeer Hussain <
[email protected]> wrote:
> *@nazeer1100126* commented on this pull request.
> ------------------------------
>
> In fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/
> AdHocApiResource.java
> <https://github.com/apache/fineract/pull/364#discussion_r121310884>:
>
> > + @GET
> + @Path("{adHocId}")
> + @Consumes({ MediaType.APPLICATION_JSON })
> + @Produces({ MediaType.APPLICATION_JSON })
> + public String retrieveAdHocQuery(@PathParam("adHocId") final Long
adHocId, @Context final UriInfo uriInfo) {
> +
> + this.context.authenticatedUser();
> +
> + final ApiRequestJsonSerializationSettings settings =
this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());
> +
> + final AdHocData adhoc =
this.adHocReadPlatformService.retrieveOne(adHocId);
> +
> + return this.toApiJsonSerializer.serialize(settings, adhoc,
this.RESPONSE_DATA_PARAMETERS);
> + }
> +
> +/* *//**
>
> Please remove unused/commented code
> ------------------------------
>
> In fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/
> AdHocWritePlatformServiceJpaRepositoryImpl.java
> <https://github.com/apache/fineract/pull/364#discussion_r121311952>:
>
> > +
> + private void logAsErrorUnexpectedDataIntegrityException(final
DataIntegrityViolationException dve) {
> + logger.error(dve.getMessage(), dve);
> + }
> +
> + //@Caching(evict = { @CacheEvict(value = "users", allEntries =
true), @CacheEvict(value = "usersByUsername", allEntries = true) })
> + @Transactional
> + @Override
> + public CommandProcessingResult updateAdHocQuery(final Long roleId,
final JsonCommand command) {
> + try {
> + this.context.authenticatedUser();
> +
> +
this.adHocCommandFromApiJsonDeserializer.validateForUpdate(command.json());
> +
> + final AdHoc adHoc = this.adHocRepository.findOne(roleId);
> + if (adHoc == null) { throw new
RoleNotFoundException(roleId); }
>
> if adHoc is null you should throw AdHocNotFoundException not
> RoleNotFoundException?
> ------------------------------
>
> In fineract-provider/src/main/java/org/apache/fineract/commands/service/
> CommandWrapperBuilder.java
> <https://github.com/apache/fineract/pull/364#discussion_r121312046>:
>
> > @@ -2904,4 +2904,43 @@ public CommandWrapperBuilder
deleteSmsCampaign(final Long resourceId) {
> this.href = "/smscampaigns/"+resourceId;
> return this;
> }
> + public CommandWrapperBuilder disableAdHoc(Long adHocId) {
> + this.actionName = "DISABLE";
> + this.entityName = "ADHOC";
> + this.entityId = adHocId;
> + this.href = "/adhoc/" + adHocId + "/disbales";
>
> make it disable. I believe it should be command parameter?
> ------------------------------
>
> In fineract-provider/src/main/resources/sql/migrations/core_
> db/V323__adhocquery.sql
> <https://github.com/apache/fineract/pull/364#discussion_r121312141>:
>
> > @@ -0,0 +1,48 @@
> +--
>
> Current migration number 327. So Your migration script number should 328
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/364#pullrequestreview-43348064>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ALCNBxjQNJtNT3K0Nn8_Q5lXo1IZtU0Uks5sDMwKgaJpZM4N2SsC>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
