Github user pranjal-goswami commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/376#discussion_r125570395
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationDomainServiceImpl.java
 ---
    @@ -552,7 +557,7 @@ private void buildNotification(String permission, 
String objectType, Long object
                
                String tenantIdentifier = 
ThreadLocalContextUtil.getTenant().getTenantIdentifier();
                Queue queue = new ActiveMQQueue("NotificationQueue");
    -           List<Long> userIds = 
retrieveUsersWithSpecificPermission(permission);
    +           List<Long> userIds = retrieveSubscribers(officeId, permission);
    --- End diff --
    
    At the time of deployment of this code, we can assume that there will be no 
topics that have been created for existing offices and users. What is your plan 
to populate the topics table for existing offices and users?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to