[ 
https://issues.apache.org/jira/browse/FINCN-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640841#comment-16640841
 ] 

ASF GitHub Bot commented on FINCN-22:
-------------------------------------

myrle-krantz commented on issue #8: Fixing bug FINCN-22:Fix TestSuite in teller
URL: https://github.com/apache/fineract-cn-teller/pull/8#issuecomment-427598116
 
 
   Hey Cabrel, this actually does fix the problem and I'm a little surprised, 
because I don't understand why.
   
   Can you please explain?
   
   Also, can you explain whey you fiddled with the gradle files?  Was it a 
necessary part of the fix?  If not, can you please remove that from your commit 
and resubmit the PR?
   
   Thanks!
   Myrle

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix TestSuite in teller
> -----------------------
>
>                 Key: FINCN-22
>                 URL: https://issues.apache.org/jira/browse/FINCN-22
>             Project: Fineract Cloud Native
>          Issue Type: Bug
>          Components: fineract-cn-teller
>            Reporter: Myrle Krantz
>            Priority: Major
>
> As a programmer I want to be able to find out quickly if my changes have 
> caused existing functionality to break.  The TestSuite class in the 
> component-test module of the fineract cn services is there to make one-click 
> testing of the services easy.
> Currently when the TestSuite of fineract-cn-teller is run, only the first 
> Test class passes.  The following test fails, and the remaining tests aren't 
> even included in the suite.  These test pass when they are run individually 
> however.  Apparently some part of the service spin up which should be part of 
> the base class is still in the child classes.  This causes spin-up to fail 
> because the spin down is not completed by the time the next class starts.
> Once this is fixed, you should also add the two missing test classes to the 
> test suite.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to