[ 
https://issues.apache.org/jira/browse/FINERACT-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789573#comment-16789573
 ] 

Mua Ndzo Laurent commented on FINERACT-696:
-------------------------------------------

[~vorburger] i am interested in solving this issue. I have gone through - 
[https://github.com/KengoTODA/findbugs-slf4j/] and how to include it in the 
codebase. I would love to take on this as my first contributions into the org 

> use SpotBugs and findbugs-slf4j to detect bad logging anti-patterns
> -------------------------------------------------------------------
>
>                 Key: FINERACT-696
>                 URL: https://issues.apache.org/jira/browse/FINERACT-696
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Michael Vorburger.ch
>            Priority: Major
>              Labels: starter
>
>  While code reviewing [https://github.com/apache/fineract/pull/464], I came 
> accross a {{catch}} & {{printStackTrace}}, which is of course wrong (it 
> should instead be, correctly, logged, instead).
> In an ideal world, it would not take human code review to catch this, but 
> just an automated build failure. This is possible using SpotBugs (not 
> FindBugs anymore; SpotBugs is the new FindBugs, it's a fully compatible 
> successor)  and [https://github.com/KengoTODA/findbugs-slf4j/] (for this 
> particular case [https://github.com/KengoTODA/findbugs-slf4j/issues/70], but 
> using findbugs-slf4j for Fineract would have value even before that's 
> implemented).
> [~myrle] you mentioned at FOSDEMO that you had hordes of volunteers just 
> waiting to have issues to working on (I'm joking) - so I was wondering if 
> perhaps you knew of anyone who would be willing to work on this one?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to