[
https://issues.apache.org/jira/browse/FINERACT-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875507#comment-16875507
]
Michael Vorburger.ch edited comment on FINERACT-765 at 6/29/19 1:28 PM:
------------------------------------------------------------------------
Something we'll have to have a closer look into when we tackle this one is make
sure that the runtime Flyway migration really doesn't use any of the Gradle
Flyway stuff.
I thought that was the case, but we had some confusion around this in
https://github.com/apache/fineract/pull/593 re. [~conradsp] "(it) appears that
some part of the gradle build configuration is carried into the war file..."
and [~awasum] " What you can do is to copy and modify the list-db SQL scripts
to change the mysql host to the dockerhost of mysql. Its a dirty fix."
When we get to making the change, we should remember to remove that {{sed}}
from the {{Dockerfile}}.
was (Author: vorburger):
Something we'll have to have a closer look into when we tackle this one is make
sure that the runtime Flyway migration really doesn't use any of the Gradle
Flyway stuff.
I thought that was the case, but we had some confusion around this in
https://github.com/apache/fineract/pull/593 re. [~conradsp] "(it) appears that
some part of the gradle build configuration is carried into the war file..."
and [~awasum] " What you can do is to copy and modify the list-db SQL scripts
to change the mysql host to the dockerhost of mysql. Its a dirty fix."
> Remove Flyway completely from Gradle build, and run it only in-App at runtime
> -----------------------------------------------------------------------------
>
> Key: FINERACT-765
> URL: https://issues.apache.org/jira/browse/FINERACT-765
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger.ch
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In https://github.com/apache/fineract/pull/582 for FINERACT-761 for
> https://github.com/apache/fineract/pull/525 for FINERACT-700, [~vishwasbabu]
> raised an interesting point:
> {quote}@vorburger : Thinking back, we could probably have simply removed all
> the flyway tasks from gradle. I am not sure if anybody was actually using
> them (the gradle tasks for migrating DB's listed in the readme are not really
> required as flyway would run anyway on application startup){quote}
> IFF nobody actually has to use those tasks during the build, then removing
> them would be a very welcome simplification!
> It's technically not "needed" for the Gradle upgrade in FINERACT-700 in the
> very short term, because after MUCH pain we've sorted the Flyway related
> issues out, but this still seems a very worthwhile simplifcation to ease
> future pain.
> I wouldn't have time for this, but perhaps someone would like to pick this up?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
