[ 
https://issues.apache.org/jira/browse/FINERACT-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16878425#comment-16878425
 ] 

Michael Vorburger.ch commented on FINERACT-765:
-----------------------------------------------

https://github.com/apache/fineract/pull/613 proposes doing this now.

Just sent this to [email protected], see 
https://lists.apache.org/thread.html/15f5e2b67419037eb7728d0d4e6c13ff956e7591a47da554585f46a5@%3Cdev.fineract.apache.org%3E:

{quote}To: <[email protected]>
Subject: FINERACT-765 Remove Flyway completely from Gradle build, and run it 
only in-App at runtime

Hello,

This affects only developers, not end-users:

Hopefully nobody has any strong objections to 
https://issues.apache.org/jira/browse/FINERACT-765 and is against 
https://github.com/apache/fineract/pull/613, which remove Flyway completely 
from the Gradle build?

So you won't be able to (once PR #613 is merged) do e.g. " ./gradlew 
migrateTenantDB" anymore - but we realized that you actually never had to 
anyway - because Flyway runs in-App at runtime during boot, anyway.

BTW this does not affect e.g. " ./gradlew createDB 
-PdbName=mifosplatform-tenants", that will still work (and is really quite 
useful), because createDB has nothing to do with Flyway.

Shout if Qs.

Best,
M.{quote}

> Remove Flyway completely from Gradle build, and run it only in-App at runtime
> -----------------------------------------------------------------------------
>
>                 Key: FINERACT-765
>                 URL: https://issues.apache.org/jira/browse/FINERACT-765
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger.ch
>            Assignee: Michael Vorburger.ch
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/fineract/pull/582 for FINERACT-761 for 
> https://github.com/apache/fineract/pull/525 for FINERACT-700, [~vishwasbabu] 
> raised an interesting point:
> {quote}@vorburger : Thinking back, we could probably have simply removed all 
> the flyway tasks from gradle. I am not sure if anybody was actually using 
> them (the gradle tasks for migrating DB's listed in the readme are not really 
> required as flyway would run anyway on application startup){quote}
> IFF nobody actually has to use those tasks during the build, then removing 
> them would be a very welcome simplification! 
> It's technically not "needed" for the Gradle upgrade in FINERACT-700 in the 
> very short term, because after MUCH pain we've sorted the Flyway related 
> issues out, but this still seems a very worthwhile simplifcation to ease 
> future pain.
> I wouldn't have time for this, but perhaps someone would like to pick this up?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to