[
https://issues.apache.org/jira/browse/FINERACT-779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881842#comment-16881842
]
Michael Vorburger.ch commented on FINERACT-779:
-----------------------------------------------
{quote}Travis CI Build Failure is totally unrelated to
[https://github.com/apache/fineract/pull/618]
{quote}
This ^^^ statement from me on [https://github.com/apache/fineract/pull/618] was
wrong... as [~vishwasbabu] on [a reply on the Fineract Dev mailing
list|https://lists.apache.org/thread.html/ee040236667982cb2d3d7527c5d24c03bd383e9497daaff980265e6b@%3Cdev.fineract.apache.org%3E]
helpfully (thank you!) pointed out:
This is not a general Travis CI broken, but a problem specifically due to the
change proposed in that PR, which leads to excessive logging, which breaks
Travis. I've changed this issue's title accordingly.
What's going on here is that, unknown to me, Spring Boot Actuator does not only
add
[https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-endpoints.html]
but also
[https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-auditing.html,]
which leads to the log at level INFO shown above (that log does not show up on
the current {{develop}} branch without Spring Boot Actuator.
By adding the following to {{fineract-provider/src/main/resources/logback.xml}}
(NB without {{...listener.AuditListener}} class name, just package) :
{code:xml}
<logger name="org.springframework.boot.actuate.audit.listener" level="debug" />
<!-- FINERACT-779 -->{code}
this does not appear anymore (on {{./gradlew clean integrationTest}}, so Travis
CI will be fine). FTR: There is still this similar log, but this one is from us
(Fineract), not Spring:
{noformat}
10:22:15.695 [SimpleAsyncTaskExecutor-4840] INFO
o.s.b.a.audit.listener.AuditListener - AuditEvent [timestamp=Wed Jul 10
10:22:15 CEST 2019, principal=mifos, type=AUTHENTICATION_SUCCESS,
data={details=org.springframework.security.web.authentication.WebAuthenticationDetails@957e:
RemoteIpAddress: 127.0.0.1; SessionId: null}{noformat}
Lastly, it's worth noting that in older [Spring Boot versions AuditListener
logged
INFO|https://github.com/spring-projects/spring-boot/blob/1.0.x/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/audit/listener/AuditListener.java]
(e.g. 1.0.x up to the one we are currently using) and [later current version
logs at
DEBUG|https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-actuator/src/main/java/org/springframework/boot/actuate/audit/listener/AuditListener.java],
by default.
Case closed.
> Travis CI broken, again
> -----------------------
>
> Key: FINERACT-779
> URL: https://issues.apache.org/jira/browse/FINERACT-779
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger.ch
> Priority: Major
>
> similarly to FINERACT-732,
> the Travis CI integration for PRs to Fineract which I recently set up seems
> to be broken,
> AGAIN?
>
> Example on [https://github.com/apache/fineract/pull/618] "The job exceeded
> the maximum log length, and has been terminated.", again?
> Reminds me FINERACT-732], but seems to be a new issue... did we very recently
> change something which is causing more extensive logging of ITs - I see A LOT
> of the following, do we really need to log this at level INFO, or could we
> just make these DEBUG:
> {noformat}01:21:21.119 [SimpleAsyncTaskExecutor-49243] INFO
> o.s.b.a.audit.listener.AuditListener - AuditEvent [timestamp=Sat Feb 23
> 01:21:21 IST 2019, principal=mifos, type=AUTHENTICATION_SUCCESS,
> data=\{details=org.springframework.security.web.authentication.WebAuthenticationDetails@957e:
> RemoteIpAddress: 127.0.0.1; SessionId: null}] 01:21:21.124
> [http-bio-8443-exec-87] INFO o.a.f.i.s.f.TenantAwareBasicAuthenticationFilter
> -
> \{"startTime":1550865081114,"totalTime":10,"method":"GET","url":"https://localhost:8443/fineract-provider/api/v1/recurringdepositaccounts/142","parameters":{"tenantIdentifier":["default"]}}
> {noformat}
> Or perhaps Travis CI (suddenly?) got more strict?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
