[ 
https://issues.apache.org/jira/browse/FINERACT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985333#comment-16985333
 ] 

Yemdjih Kaze Nasser commented on FINERACT-796:
----------------------------------------------

I will check on this and make a pull request

> Use Hikari instead of Tomcat Connection Pool
> --------------------------------------------
>
>                 Key: FINERACT-796
>                 URL: https://issues.apache.org/jira/browse/FINERACT-796
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Major
>
> InĀ [https://github.com/apache/fineract/pull/642] for FINERACT-724, ivan333m 
> said:
> {quote}New version of spring-boot-starter-data-jpa uses HikariCP as default 
> connection pool instead of tomcat-jdbc. So I need to add this dependency. 
> Also I have excluded HikariCP in the latest commit.{quote}
> Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc 
> default to HikariCP, and that e.g. 
> https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database
>  explicitly states:
> {quote}We prefer HikariCP for its performance and concurrency. If HikariCP is 
> available, we always choose it. Otherwise, if the Tomcat pooling DataSource 
> is available, we use it.{quote}
> I think we should eventually replace our use of the Tomcat JDBC Connection 
> Pool with Hikari.
> I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a 
> pre-req. to it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to