[
https://issues.apache.org/jira/browse/FINERACT-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17008377#comment-17008377
]
Michael Vorburger commented on FINERACT-726:
--------------------------------------------
> that "./gradlew integrationTest" fails for me locally with this change
I've just figured it out, it was a dumb oversight (RestAssured just needed MIME
for JSON).
https://github.com/apache/fineract/pull/678 raised for review. Let's get that
reviewed & merged, and then:
Some other resource classes may need the same fix? (Myself or anyone else could
do that by applying a very similar pattern.)
{quote}And I suspect that this will have impacts on things such as integration
tests in Fineract, the Mifos AngularJS front-end, and things like Android
mobile apps which will have to be dealt with.{quote}
This is going to be "interesting" - this change, while a required very Good
Idea, will break all existing API clients!!!
> Changes to /authentication API's to pass data as part of request body
> ---------------------------------------------------------------------
>
> Key: FINERACT-726
> URL: https://issues.apache.org/jira/browse/FINERACT-726
> Project: Apache Fineract
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Vishwas Babu A J
> Assignee: Michael Vorburger
> Priority: Major
> Labels: 2019-mifos-gsoc, gsoc, p1, volunteer
> Fix For: 1.4.0
>
>
> Fineract supports authentication either using Basic auth or Oauth. The
> initial authentication is done using the endpoints described at
> [https://demo.openmf.org/api-docs/apiLive.htm#authentication_basicauth] and
> [https://demo.openmf.org/api-docs/apiLive.htm#authentication_oauth]
> Both rely on passing the username and password as URL query parameters.
> Ex, the endpoint for /authentication is
> POST :
> [https://localhost:8443/fineract-provider/api/v1/authentication?username=mifos&password=password&tenantIdentifier=default]
>
> We would want to change the same to
> POST
> [https://localhost:8443/fineract-provider/api/v1/authentication?tenantIdentifier=default]
> and pass the username and password as apart of the post body in json format.
> Ex:
> {code:java}
> {
> "username":"mifos",
> "password":"password"
> }{code}
>
> After making this change, the APIdocs and integration test cases would have
> to be updated accordingly
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
