[
https://issues.apache.org/jira/browse/FINERACT-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013742#comment-17013742
]
Michael Vorburger commented on FINERACT-702:
--------------------------------------------
This issue can be closed once my [https://github.com/apache/fineract/pull/685]
and [https://github.com/apache/fineract/pull/684] in addition to Awasum's
[https://github.com/apache/fineract/pull/670/] (which I just merged right now)
will also have been merged. Unless Awasum you were planning to do anything
further here, but I think we did what we code here and made a great start, and
should track further improvements if any in more specialized dedicated issues,
such as FINERACT-696, which is now unblocked based on the work done under this
issue.
> Integrate SpotBugs and fail build if equals but not hashCode is implemented
> ---------------------------------------------------------------------------
>
> Key: FINERACT-702
> URL: https://issues.apache.org/jira/browse/FINERACT-702
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger
> Assignee: Awasum Yannick
> Priority: Major
> Labels: starter
> Fix For: 1.4.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This project should activate SpotBugs (the successor to FindBugs) and make it
> fail the build for any violations to a at least a subset of rules which are
> almost always guaranteed to be bugs.
> For example,
> https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#he-class-defines-equals-and-uses-object-hashcode-he-equals-use-hashcode
> which would have caught what I manually spotted (but shouldn't have to) in
> https://github.com/apache/fineract/pull/524.
> FINERACT-402 has some history, but it's clearly not activated to enforce.
> FINERACT-696 could then be built on top of this.
> [~myrle] perhaps you know of any volunteer interested in doing this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
