[
https://issues.apache.org/jira/browse/FINCN-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021026#comment-17021026
]
Juhan Aasaru commented on FINCN-172:
------------------------------------
I copy the same info here that I wrote to Rohit to mailing list to which
branches this change should be done.
=====
I think the first goal would be to get fineract-cn-identity running on new
Spring Boot version 2.2 since Identity doesn't depend on any other fineract
project (it only depends on libraries). Once we have accomplished that then
getting rest of the services moved is mostly just a lot of copy-paste work.
For this we have to include in the spring boot update the list of Fineract
libraries Identity depends on. These are (taken from
fineract-cn-identity/shared.gradle):
frameworkcrypto : '0.1.0-BUILD-SNAPSHOT',
frameworkanubis : '0.1.0-BUILD-SNAPSHOT',
frameworkapi : '0.1.0-BUILD-SNAPSHOT',
frameworktest : '0.1.0-BUILD-SNAPSHOT',
frameworklang : '0.1.0-BUILD-SNAPSHOT',
frameworkasync : '0.1.0-BUILD-SNAPSHOT',
frameworkcassandra : '0.1.0-BUILD-SNAPSHOT',
frameworkcommand : '0.1.0-BUILD-SNAPSHOT',
But if we just update those libraries then it would break everything that is
currently working. For this I created branch "spring_boot_2" for each of the
libraries and declared their version to be "spring_boot_2-SNAPSHOT". For
example:
[https://github.com/apache/fineract-cn-lang/blob/spring_boot_2/build.gradle#L51]
So if we push something to branch "spring_boot_2" in apache/fineract-cn-lang
then the artifact that is built and deployed by travis-ch will have verison
number "spring_boot_2-SNAPSHOT". And 0.1.0-BUILD-SNAPSHOT remains unaffected.
So I did that and now you see that the fineract-cn-identity in branch
"spring_boot_2" depends on these versions:
[https://github.com/apache/fineract-cn-identity/blob/spring_boot_2/shared.gradle#L19]
Rohit. As step #2 please make sure you get Idenity woring with Spring Boot 2
and create pull requests to all of the needed libraries Identity depends + a
pull request to Identity itself and please make your pull requests point branch
"spring_boot_2" (and not "develop"):
In order not to send your other changes, please frirst create clean branches to
all of your local forks (or even better - create new forks under your personal
github name for this).
I know creating all these pull requests is pain (and also they depend on each
other so some of the pull request builds won't pass at first - ignore that).
There is a cure for that but please bare with me on this one and once this is
luckily done we might find a way where you can push code directly.
> Upgrade all fineract-cn-* apps to latest Spring Boot / Spring Framework
> -----------------------------------------------------------------------
>
> Key: FINCN-172
> URL: https://issues.apache.org/jira/browse/FINCN-172
> Project: Fineract Cloud Native
> Issue Type: Improvement
> Reporter: Juhan Aasaru
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Proposed by [~Kwesi] :
> 1. Upgrading Fineract CN from Spring Boot 1.4.1 to 2.1.+
> 2. Upgrading Fineract CN from Spring Framework from 4.3.3 to 5.1.+
>
> This should be done in the same time to all fineract-cn-* applications
> (similar to https://issues.apache.org/jira/browse/FINCN-170 ) - so one would
> create pull requests for all apps and once the work is accepted all pull
> requests would be merged together.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
