[ 
https://issues.apache.org/jira/browse/FINERACT-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17082455#comment-17082455
 ] 

Michael Vorburger commented on FINERACT-889:
--------------------------------------------

I'm going to add these DRIVERCLASS_NAME, PROTOCOL and SUB_PROTOCOL properties 
to docker-compose.yml for illustration for upcoming FINERACT-762, but I'm not 
actually going to change them, because even though different formats and naming 
conventions are a little bit of a mess,
changing them now leads to backwards incompatibility, so for now let's just 
leave as is (but still remove PORT). I'm lowering the Priority of this issue to 
Minor - it's more of a "clean up" than anything really required.

> Merge (old) DRIVERCLASS_NAME/PROTOCOL/SUB_PROTOCOL) with (new) 
> fineract_tenants_driver/fineract_tenants_url
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-889
>                 URL: https://issues.apache.org/jira/browse/FINERACT-889
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger
>            Priority: Minor
>
> While looking into FINERACT-762, I've found 
> org.apache.fineract.infrastructure.core.boot.JDBCDriverConfig and noticed 
> that its (old) DRIVERCLASS_NAME, PROTOCOL and SUB_PROTOCOL properties, who's 
> defaults are defined in META-INF/spring/jdbc.properties (but can be 
> overriden), overlap with the (newer) fineract_tenants_driver & 
> fineract_tenants_url. (There was no equivalent to fineract_tenants_uid and 
> fineract_tenants_pwd in the old scheme.)
> This is confusing and it would be nicer if there were only the newer 
> properties.
> Also, PORT is actually useless (un-used), so proposed to be remove in 
> https://github.com/apache/fineract/pull/756.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to