[ 
https://issues.apache.org/jira/browse/FINERACT-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098378#comment-17098378
 ] 

Michael Vorburger commented on FINERACT-855:
--------------------------------------------

[~ptuomola] interesting find! That {{Thread.sleep(15000);}} in line 119 of 
{{SchedulerJobHelper}} you "snuck in" :D could be a work around then. Something 
like "more clever fix" you describe would of course be much better (also 
because it would slow down all 24 tests using {{executeJob()}} by 15s (24 * 15s 
= 360s = 6 minutes extra on all integrationTest)... I'm not very familiar with 
that particular code myself, but from a first quick glance at it, comparing it 
to similar systems I've seen elsewhere in past lifes, shouldn't 
{{runSchedulerJob()}} return some sort of Job Run identifier which can 
subsequently be checked? This project would obviously be honoured if you were 
so inclined to make a contribution for this... :D

> RecurringDepositTest
> --------------------
>
>                 Key: FINERACT-855
>                 URL: https://issues.apache.org/jira/browse/FINERACT-855
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Michael Vorburger
>            Priority: Major
>
> while attempting to understand FINERACT-852, and locally pulling and running 
> https://github.com/apache/fineract/pull/719, it failed for me, and we have a 
> note about a similar failure in https://github.com/apache/fineract/pull/642, 
> this may be  another flaky one?
> {code}> Task :integrationTest                                                 
>                                                                               
>                                                                               
>                                                                               
>                                                                               
>                                           
> org.apache.fineract.integrationtests.RecurringDepositTest > 
> testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX 
> FAILED                                                                        
>      java.lang.AssertionError at RecurringDepositTest.java:836{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to