Michael Vorburger created FINERACT-942:
------------------------------------------
Summary: Make Checkstyle detect bad logging anti-patterns (and fix
problems found)
Key: FINERACT-942
URL: https://issues.apache.org/jira/browse/FINERACT-942
Project: Apache Fineract
Issue Type: Improvement
Reporter: Michael Vorburger
A particularly useful part of FINERACT-821, helping to detect real errors in
Fineract and not just formating, would be to enable the following in
fineract-provider/config/checkstyle/checkstyle.xml, and fix any problems that
this finds:
1. RegexpSinglelineJava / printStackTrace
2. IllegalCatch, IllegalThrows, MutableException, AvoidHidingCauseExceptionCheck
3.
[EmptyCatchBlock|https://checkstyle.sourceforge.io/config_blocks.html#EmptyCatchBlock]
Nota bene that we already have FINERACT-696, but this is complementary to that.
One thing this should detect is e.g. the bad wrong emtpy
catch(MessagingException e) in EmailMessageJobEmailServiceImpl.
It may lead to more of FINERACT-932, which would be a Good Thing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
